Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What versions were used in March? #2

Open
tkamm opened this issue Jun 8, 2021 · 6 comments
Open

What versions were used in March? #2

tkamm opened this issue Jun 8, 2021 · 6 comments

Comments

@tkamm
Copy link

tkamm commented Jun 8, 2021

I'm trying to work through the tutorials in June 2021 and having some issues that I suspect are due to pip installing the latest releases. This might be fixed by updating the notebooks to use the versions as they were in March 2021. I was okay with part 1, but have issues with part 2. I haven't tried parts 3 and 4 yet.

@cmacdonald
Copy link
Contributor

cmacdonald commented Jun 8, 2021

PyTerrier had a release since March, but nothing should have broken. Potentially a dependency has broken, but we're not aware of it. Could you post the error you experience and we can make a recommendation?

@tkamm
Copy link
Author

tkamm commented Jun 8, 2021

With the latest releases in part 2 notebook, I could not get success on lmart_x_pipe.fit duee to this errorL
"Number of rows 32776 exceeds upper limit of 10000 for a query"
Once I specified:
!pip install --upgrade fastrank==0.7.0 lightgbm==3.1.1
!pip install python-terrier==0.5.0

then lmart_x_pipe.fit worked, but I could not:
from pyterrier.measures import *
so I reverted back to
eval_metrics=['map','ndcg'],
and was able to finish the notebook.

@cmacdonald
Copy link
Contributor

For from pyterrier.measures import *, you will need 0.6

This I havent seen before
"Number of rows 32776 exceeds upper limit of 10000 for a query"

We'll investigate over the next few days and let you know.

@cmacdonald
Copy link
Contributor

"Number of rows 32776 exceeds upper limit of 10000 for a query"

Was that error created when fitting using xgBoost, FastRank or LightGBM?

@tkamm
Copy link
Author

tkamm commented Jun 8, 2021

lightgbm==3.2.1
I estimate that 3.1.1 was the version used in March and I confirmed that it works.
3.2.0 is where it starts giving the "Number of rows" error
I just confirmed that python-terrier==0.6.0 and fastrank==0.7.0, both the latest versions, seem to work as expected.

@cmacdonald
Copy link
Contributor

Thanks. I have pegged the lighgbm version for notebook2. Once I have verified it, I will close this issue, thanks for the report.

I have promoted your comment about compatibility to a PyTerrier issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants