Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to aiobotocore 2.8.0 #321

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Nov 29, 2023

https://github.com/aio-libs/aiobotocore/releases/tag/2.8.0

This in particular allows using botocore>=1.32.1, which comes with a massive decrease in installed size: 83MB -> 20MB (see boto/botocore#2365 (comment) and/or aio-libs/aiobotocore#1056 for more details).


Thanks for aioboto3!

@huonw
Copy link
Contributor Author

huonw commented Nov 29, 2023

This currently fails due to test_patches.py:

Boto3 version: 1.33.1 aiobotocore version: 2.8.0
Digest of copy:7f9edd96f418e09c00d26538a7382b217e0843e5 not found in: {'c4423d0a6d3352553befdf0387987c09812fcaff', 'e8154a4de3b97dd2ab29d250c005b03e8fc7ed71'}

It looks like the most recent change to boto/boto3#3946 is https://github.com/boto/boto3/blob/develop/boto3/s3/inject.py#L371-L450.

I think no change is required to the code, just blessing the 7f9edd96f418e09c00d26538a7382b217e0843e5 hash, because aioboto3 doesn't use https://github.com/boto/s3transfer and the CRTTransferManager there that's missing the .copy method.

Breadcrumbs:

  • the preferred_transfer_client property is only read by _should_use_crt
  • _should_use_crt is only used by create_transfer_manager
  • aioboto3 doesn't call either

https://github.com/boto/boto3/blob/5d80baef83e3ea5f14565f5fa3bd90339dd67f47/boto3/s3/transfer.py#L154-L205

@huonw
Copy link
Contributor Author

huonw commented Dec 6, 2023

Heya @terrycain, thanks for this library! Do you have thoughts on this PR? (A gentle ping in case you missed it! 😄 )

@terricain
Copy link
Owner

Nice, sorry for the delay, go ahead and update test_patches.py and we'll get this merged.

@fritzpaz
Copy link

fritzpaz commented Dec 8, 2023

I just opened a PR to @huonw with the test fix, and a PR straight into @terrycain's main to try helping expediting all of this. Thanks to both of you guys for the contributions to the entire community!
#322

@terricain terricain merged commit e81b87a into terricain:main Dec 8, 2023
2 checks passed
@terricain
Copy link
Owner

v12.1.0 is out

@huonw huonw deleted the new-aiobotocore branch December 9, 2023 03:32
@huonw
Copy link
Contributor Author

huonw commented Dec 9, 2023

Thank you! And thanks @fritzpaz for saving me some effort 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants