Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue_comment "RC publish" workflow #427

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

nickgraz
Copy link
Contributor

@nickgraz nickgraz commented Sep 8, 2023

Using this actions/checkout#331 (comment) to get the RC publish workflow working.

See this for more info https://terraformationteam.slack.com/archives/C01C69KA23Y/p1694187601980789

@nickgraz nickgraz requested a review from a team as a code owner September 8, 2023 15:39
@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 4:10pm

@github-actions github-actions bot added the patch label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

To increment version on merge, please add one of patch (default), minor, or major label to this PR.

@charlie-tf
Copy link
Contributor

publish rc

@charlie-tf
Copy link
Contributor

pub*****c

Oh, this runs the old version, dang

@@ -10,12 +12,17 @@ jobs:
if: ${{ github.event.issue.pull_request }} && contains(github.event.comment.body, 'publish rc')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- id: 'get-branch'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this step have a name?

@nickgraz nickgraz removed the patch label Sep 8, 2023
@nickgraz nickgraz merged commit ce1f8fe into main Sep 8, 2023
@nickgraz nickgraz deleted the ng/fix-rc-comment-workflow branch September 8, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants