Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify a negative index when loading from a db #964

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

keckler
Copy link
Member

@keckler keckler commented Nov 15, 2022

Description

Add the ability to specify a negative index when loading from a DB. This allows one to load the EOC node without knowing how many nodes are in that cycle.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@keckler keckler requested a review from john-science November 15, 2022 21:01
@john-science
Copy link
Member

Is this meant for this ticket?

@keckler
Copy link
Member Author

keckler commented Nov 15, 2022

Nope, different thing!

Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's a small change. It's clear, and obvious to understand.

It doesn't break backwards compatibility.

And it's alone in a PR. Cool.

@john-science john-science merged commit 36fe1bc into terrapower:main Nov 16, 2022
@keckler keckler deleted the loadNegative branch November 24, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants