Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Helix constructor to be more correct #558

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Improving Helix constructor to be more correct #558

merged 1 commit into from
Feb 4, 2022

Conversation

john-science
Copy link
Member

Description

The constructor of the Helix class is a bit off. The default value for mult should be 1.0. And it does not make physical sense to try and fully define the geometry of a helix without defining non-None values for: od, helixDiameter, and axialPitch. So all three of those are now mandatory, with no defaults.

Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

@john-science john-science added the enhancement New feature or request label Feb 4, 2022
@john-science john-science requested a review from ntouran February 4, 2022 00:06
@john-science
Copy link
Member Author

This PR will close #533

@john-science john-science merged commit 22ebd1a into terrapower:master Feb 4, 2022
@john-science john-science deleted the helix_inputs branch February 4, 2022 21:11
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@john-science @scottyak
Improving Helix constructor to be more correct (terrapower#558)
83ceb82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntouran ntouran Awaiting requested review from ntouran

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@john-science