-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Requirements and QA to Docs #2076
base: main
Are you sure you want to change the base?
Conversation
Okay, this is working great. But I am now getting a TON of Sphinx warnings: WARNING: Ignored `filter:progid:DXImageTransform.Microsoft.gradient(GradientType=0,StartColorStr="#f9f9f9", EndColorStr="#e0e0e0")` at 16:4443, unknown property.
WARNING: Ignored `text-shadow:0 1px 0 #c4def1` at 16:4687, unknown property.
WARNING: Ignored `background-image:-webkit-linear-gradient(top, #bddef4 0%, #79ace9 100%)` at 16:4753, invalid value.
WARNING: Ignored `background-image:-o-linear-gradient(top, #f0f0f0 0%, #dadada 100%)` at 16:6528, invalid value.
WARNING: Ignored `filter:progid:DXImageTransform.Microsoft.gradient(GradientType=0,StartColorStr="#f0f0f0",
WARNING: Ignored `box-shadow:0 0 3px #444` at 28:2080, unknown property.
WARNING: Anchor defined twice: 'setting-up-the-blueprints'
WARNING: Anchor defined twice: 'nuclide-flags'
WARNING: Anchor defined twice: 'defining-fuel-management'
WARNING: Anchor defined twice: 'id13'
WARNING: Anchor defined twice: 'new-features'
WARNING: Anchor defined twice: 'api-changes'
WARNING: Anchor defined twice: 'bug-fixes'
WARNING: Anchor defined twice: 'quality-work'
WARNING: Anchor defined twice: 'bug-fixes'
WARNING: Anchor defined twice: 'quality-work'
WARNING: Anchor defined twice: 'subpackages'
WARNING: Anchor defined twice: 'submodules'
WARNING: Anchor defined twice: 'T_ARMI_MAT_PROPERTIES1'
WARNING: Anchor defined twice: 'T_ARMI_MAT_FLUID0'
WARNING: Anchor defined twice: 'submodules'
WARNING: Anchor defined twice: 'id1'
WARNING: Anchor defined twice: 'id2'
WARNING: Anchor defined twice: 'I_ARMI_MAT_FLUID' The docs look fine though. |
This is probably because you have a file getting processed by sphinx 2x somewhere via an include. If you add that file to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review this at the high level (not commenting on content since that is being reviewed by @ntouran)
There are minor formatting issues with the PDF (some tables and text includes run off the page, and some math isn't rendering in the PDF that renders fine in HTML. I sent screencaps to you offline.
In the QA section (HTML), it appears I can click from an impl or test back to a requirement, but I can't click the impl/test link from the requirement (I get a "page does not exist" error).
Looks good though! Let me know if some of these things I commented on are out of scope.
@opotowsky I cannot seem to change all these warnings from simplepdf. So I opened a ticket; useblocks/sphinx-simplepdf#109 Hopefully, this is an easy fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok after all the troubleshooting, I re-approve!
What is the change?
Here I add a "QA Documentation" section to the ARMI docs. This section will have:
Why is the change being made?
close #2064
This is part of on-going work to improve the documentation of ARMI's high-level design requirements, and to open-source that information.
Checklist
doc
folder.pyproject.toml
.