Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check on the grid/component consistency in the blueprints #2045

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

keckler
Copy link
Member

@keckler keckler commented Jan 4, 2025

What is the change?

Close #1400 .

This PR adds a check on the grids associated with a block to ensure that the components that are supposed to be in the grid (based on them having the latticeIDs attribute) actually are, and in the correct number.

Why is the change being made?

#1400 pointed out that there can be inconsistency here by pretty simple user errors. This has come up in my own work, and having ARMI be more robust to this kind of error is desirable.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@keckler keckler requested a review from john-science January 4, 2025 17:19
@john-science john-science added the enhancement New feature or request label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latticeIDs and associated grids can be inconsistent
2 participants