Removing SmartList & adding coverage #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-science
added
cleanup
opotowsky
reviewed
Oct 31, 2024
| @@ -44,6 +44,7 @@ jobs: | |||
| mpiexec -n 2 --use-hwthread-cpus coverage run --rcfile=pyproject.toml -m pytest --cov=armi --cov-config=pyproject.toml --cov-report=lcov --cov-append --ignore=venv armi/tests/test_mpiParameters.py || true | |||
| mpiexec -n 2 --use-hwthread-cpus coverage run --rcfile=pyproject.toml -m pytest --cov=armi --cov-config=pyproject.toml --cov-report=lcov --cov-append --ignore=venv armi/tests/test_mpiDirectoryChangers.py || true | |||
| coverage combine --rcfile=pyproject.toml --keep -a | |||
| coverage report --rcfile=pyproject.toml -i --skip-empty --skip-covered --sort=cover --fail-under=90 | |||
There was a problem hiding this comment.
MWAHAHAHHAHAHHAHAHA
YESSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
opotowsky
reviewed
Oct 31, 2024
|
|
||
| def test_issueWarningOnFindingText(self): | ||
| with textProcessors.SequentialReader(self._DUMMY_FILE_NAME) as sr: | ||
| warningMsg = "Oh no" |
drewj-tp
added a commit
that referenced
this pull request
Nov 7, 2024
…u-rotate-with-pin-dep * zprince/component_flux_up: fix linting release notes Enabling axial expansion with detailed depletion (#1954) Improving error testing (#2004) Addressing reviewer comments for component pin mg fluxes Removing mystery coverage line from tests (#2003) beef up assertions resolve fixme org imports No need to recast strings to strings Finishing up the numProcessors -> nTasks conversion (#2002) Using one-block reactor for component flux test Supporting Python 3.13 (#1996) Removing SmartList & adding coverage (#1992) Update `copyOrWarn` and `getFileSHA1Hash` to account for directories (#1984) Removing broken plot (#1994) Adding unit tests for `CylindricalComponentsDuctHetAverageBlockCollection` (#1991) Allowing creation of partially heterogeneous assemblies for 1D XS model (#1949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
textProcessors.py.textProcessors.pyfromtest_interfaces.py.testProcessors.py::SmartListfrom the API.--fail-under=90.Why is the change being made?
Last night, I was trying to add code coverage to
textProcessors.py, on general principles.And I noticed two strange things:
textProcessors.pywere intest_interface.pyfor now reason. So I moved those intotextProcessors.py.SmartListintextProcessors.pywas totally broken. I found multiple bugs in that class and it's usage while trying to write tests for it that prove it has not worked in at least four years. So, it is unused and I removed it.Notes
--fail-underflag in another branch and it worked.Checklist
docfolder.pyproject.toml.