Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating cluster settings #1958

Merged
merged 12 commits into from
Oct 21, 2024
Merged

Updating cluster settings #1958

merged 12 commits into from
Oct 21, 2024

Conversation

mbk-tp
Copy link
Contributor

@mbk-tp mbk-tp commented Oct 17, 2024

What is the change?

  • Removing the setting mpiTasksPerNode
  • Renaming numProcessors to nTasks

Why is the change being made?

Updating terminology to something more modern.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ john-science
✅ mbk-tp
❌ Bharat Medasani


Bharat Medasani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@john-science john-science self-requested a review October 17, 2024 16:46
@john-science john-science added the feature request Smaller user request label Oct 17, 2024
@john-science
Copy link
Member

Can you add a release not here: https://github.com/terrapower/armi/blob/main/doc/release/0.4.rst?plain=1#L42

It should says "Renaming numProcessors to nTasks".

doc/release/0.4.rst Outdated Show resolved Hide resolved
doc/release/0.4.rst Outdated Show resolved Hide resolved
@mbk-tp mbk-tp mentioned this pull request Oct 17, 2024
7 tasks
@john-science john-science changed the title Renaming some settings Updating cluster settings Oct 17, 2024
@john-science john-science self-requested a review October 17, 2024 17:38
doc/release/0.4.rst Outdated Show resolved Hide resolved
@john-science john-science self-requested a review October 17, 2024 17:43
@john-science john-science merged commit 1f70838 into terrapower:main Oct 21, 2024
11 checks passed
drewj-tp added a commit that referenced this pull request Oct 21, 2024
* origin/main:
  Updating cluster settings (#1958)
  Reducing warnings while building the docs (#1959)
  Moving anl-afci-177 test files to their own directory (#1957)
drewj-tp added a commit that referenced this pull request Oct 21, 2024
john-science added a commit that referenced this pull request Oct 21, 2024
john-science added a commit that referenced this pull request Oct 21, 2024
drewj-tp added a commit that referenced this pull request Oct 21, 2024
* main:
  Revert "Updating cluster settings (#1958)" (#1965)
opotowsky added a commit that referenced this pull request Oct 22, 2024
drewj-tp added a commit that referenced this pull request Oct 22, 2024
* main:
  Allowing users to define flag names with digits (#1966)
  Revert "Updating cluster settings (#1958)" (#1965)
opotowsky added a commit that referenced this pull request Oct 22, 2024
drewj-tp added a commit that referenced this pull request Oct 23, 2024
…xial-linkage

* origin/main:
  Loading some ARMI DBs without the App that created them (#1917)
  Revert "Revert "Updating cluster settings (#1958)" (#1965)" (#1969)
  Allowing users to define flag names with digits (#1966)
  Revert "Updating cluster settings (#1958)" (#1965)
  Updating cluster settings (#1958)
  Reducing warnings while building the docs (#1959)
  Moving anl-afci-177 test files to their own directory (#1957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants