Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Reactor.moveList to Reactor.moves #1881

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

john-science
Copy link
Member

What is the change?

I am renaming Reactor.moveList to Reactor.moves.

(There is only one downstream project that I can find that might be affected by this change.)

Why is the change being made?

The attribute is actually a dict and not a list. And this is one of the main reasons we don't inject the variable type into the variable name when we write code.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Sep 16, 2024
@john-science john-science linked an issue Sep 17, 2024 that may be closed by this pull request
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy PR to approve. Since the downstream updates are queued up, go ahead and merge when you feel this is appropriate

@john-science john-science merged commit f3d16df into main Sep 18, 2024
19 checks passed
@john-science john-science deleted the moveList_isa_bad_name branch September 18, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactor.moveList is a dictionary
2 participants