Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Axial Expansion #1861

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Refactor Axial Expansion #1861

merged 5 commits into from
Sep 10, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented Sep 9, 2024

What is the change?

This PR refactors of the axial expansion functionality in ARMI. A new directory is structure is created to enable better traceability with testing and general maintainability. Some imports are added to the new __init__.py file to perfectly preserve the ARMI API, so that this change does not require any downstream changes.

Original

armi/reactor/converters/
|-- axialExpansionChanger.py

New

armi/reactor/converters/axialExpansionChanger
|-- __init__.py
|-- assemblyAxialLinkage.py
|-- axialExpansionChanger.py
|-- expansionData.py

Why is the change being made?

The axialExpansionChanger.py file was pretty long, and there is potentially a lot of work coming up on this file. So we are trying to make the future work cleaner.

I just wanted to do this now, as I see a lot of axial expansion work happening soon. Let's just get the necessary cleanup work out of the way.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Sep 9, 2024
@john-science john-science changed the title Refactor axial expansion Refactor Axial Expansion Sep 9, 2024
@john-science john-science mentioned this pull request Sep 9, 2024
7 tasks
Copy link
Contributor

@drewj-tp drewj-tp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @john-science I don't have any major suggestions here. Some nits that I'm not going to hold as blockers for this PR

armi/reactor/blocks.py Outdated Show resolved Hide resolved
doc/user/inputs.rst Outdated Show resolved Hide resolved
armi/reactor/blocks.py Outdated Show resolved Hide resolved
john-science and others added 2 commits September 9, 2024 16:46
Co-authored-by: Drew Johnson <anjohnson@terrapower.com>
@john-science john-science merged commit 5b3984b into main Sep 10, 2024
21 checks passed
@john-science john-science deleted the refactor_axial_expan branch September 10, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants