Allow merging a solute with zero area #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-science
reviewed
Sep 6, 2024
| from armi import runLog | ||
| from armi.reactor import blocks, components, grids |
There was a problem hiding this comment.
I see you keep doing this. And, fine.
Just to be clear, I don't actually think this improve readability. And I have explicitly done the opposite in hundreds of ARMI files.
There was a problem hiding this comment.
It's being done automatically by my linter, maybe I don't have it configured correctly?
john-science
reviewed
Sep 6, 2024
john-science
reviewed
Sep 9, 2024
john-science
approved these changes
Sep 9, 2024
Not yet, no. I don't expect any issues but I still need to test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
The block converter
mergeComponentswas implemented to not allow merging any components that had zero area. This should be loosened to allow for merging a zero area solute into a non-zero area solvent.Why is the change being made?
There are many situations where we don't care about modeling zero-area components (for example, a gap that has completely closed) and it is helpful to be able to merge these components into another component so that they don't appear on the block.
Checklist
docfolder.pyproject.toml.