-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting syncdbAfterWrite working #1857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-science
reviewed
Sep 6, 2024
john-science
reviewed
Sep 6, 2024
zachmprince
force-pushed
the
syncDbAfterWrite
branch
from
September 6, 2024 21:14
8d2854f
to
f2dac01
Compare
Co-authored-by: John Stilley <1831479+john-science@users.noreply.github.com>
@zachmprince Remind me, did we run those downstream tests successfully? Last I heard, you sounded convinced, but were worried about some unrelated errors? How are you feeling now? |
I am confident these changes are not affecting downstream applications. Test failure I ran into is unrelated. If you are okay merging it, please do! It's all okay on my side. |
john-science
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
This PR modifies
Database3.syncToSharedFolder
so that it closes theh5py.File
before trying to copy the h5 file to the working directory. The full process is:h5py.File.close()
and set the object toNone
.Tests were also added to ensure the
syncDbAfterWrite
setting behaves as expected.Why is the change being made?
Partial resolution to #1794
Previously, setting
syncDbAfterWrite
caused aPermissionError
due to the h5 file not being closed before trying to copy it.Checklist
doc
folder.pyproject.toml
.