Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --skip-inspection to compare-suites #1842

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

john-science
Copy link
Member

What is the change?

Adding a --skip-inspection flag to the CompareSuites CLI, the flag will turn off the checkInputs() that validates the settings files in each DB that is being compared.

Why is the change being made?

A feature request, to help streamline some downstream workflows.

close #1840


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the feature request Smaller user request label Aug 29, 2024
@john-science john-science requested a review from opotowsky August 29, 2024 03:05
armi/cases/suite.py Outdated Show resolved Hide resolved
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I meant to comment and not approve. This supersedes my proir review

doc/release/0.4.rst Outdated Show resolved Hide resolved
Co-authored-by: Arrielle Opotowsky <arrielle.opotowsky@gmail.com>
@john-science john-science requested a review from opotowsky August 29, 2024 23:03
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works! Thanks so much!

@opotowsky opotowsky merged commit 9ea428b into terrapower:main Aug 30, 2024
11 checks passed
@john-science john-science deleted the compare_skip_insp branch August 30, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --skip-inspection flag to compare-suites CLI
2 participants