Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing defunct flags CORE and REACTOR #1835

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Removing defunct flags CORE and REACTOR #1835

merged 3 commits into from
Aug 27, 2024

Conversation

john-science
Copy link
Member

What is the change?

Here I removed two flags that are barely used and are definitely unnecessary.

Why is the change being made?

To close #1833


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Aug 26, 2024
@john-science john-science requested a review from keckler August 26, 2024 23:49
@john-science john-science requested a review from keckler August 27, 2024 01:33
@john-science john-science merged commit 412c1e7 into main Aug 27, 2024
21 checks passed
@john-science john-science deleted the rm_defunct_flags branch August 27, 2024 18:17
@mgjarrett mgjarrett mentioned this pull request Aug 28, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants