Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing DerivedShape.getArea() for cold=true #1831

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Fixing DerivedShape.getArea() for cold=true #1831

merged 5 commits into from
Aug 27, 2024

Conversation

john-science
Copy link
Member

What is the change?

Fixed a bug in DerivedShape.getArea() in the case when cold=true.

Why is the change being made?

To close #1424

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the bug Something is wrong: Highest Priority label Aug 23, 2024
@john-science john-science requested a review from keckler August 23, 2024 16:59
keckler
keckler approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

armi/reactor/components/__init__.py Outdated Show resolved Hide resolved
@john-science john-science requested a review from keckler August 23, 2024 20:48
@keckler
Copy link
Member

keckler commented Aug 25, 2024

Everything looks good by me, thanks @john-science !

@john-science
Copy link
Member Author

I have confirmed that this bug fix does not break any downstream unit tests.

@john-science john-science changed the title Fixing DerivedShape for cold=true Fixing DerivedShape.getArea() for cold=true Aug 27, 2024
@john-science john-science merged commit 73688cc into main Aug 27, 2024
21 checks passed
@john-science john-science deleted the derived_shaped_cold_true branch August 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keckler keckler keckler approved these changes

Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DerivedShape.getArea() doesn't respect cold=True argument
2 participants
@john-science @keckler