Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluid volumes after prescribed axial expansion #1828

Merged
merged 9 commits into from
Sep 16, 2024

Conversation

mgjarrett
Copy link
Contributor

@mgjarrett mgjarrett commented Aug 21, 2024

What is the change?

Clear the cached volume for fluid components in order for them to be updated post axial expansion. Ensures consistency with the parent block height and that total assembly fluid mass is conserved

Why is the change being made?

After prescribed axial expansion is applied to a block, the cache should be cleared from all components so that the component volume can be recalculated based on the new block height. It was only being done for solid components, which left fluid components in a state where their volume was not consistent with their parent block's height.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@mgjarrett mgjarrett added the bug Something is wrong: Highest Priority label Aug 21, 2024
@mgjarrett mgjarrett requested a review from albeanth August 21, 2024 00:27
mgjarrett and others added 3 commits August 21, 2024 08:09
Co-authored-by: Michael Jarrett <mjarrett@terrapower.com>
Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Easy enough!

Being picky, if you could update the "what is the change" section of the PR, that may be nice. Could be a simple "clear the cached volume for fluid components in order for them to be updated post axial expansion. ensures consistency with the parent block height and that total assembly fluid mass is conserved".

@albeanth albeanth marked this pull request as draft August 21, 2024 15:30
@albeanth
Copy link
Member

Converting this to draft until it's ready to be merged -- we have downstream testing that we need to do before this can be merged. Once said testing is done, we will crack this back open for merging!

@mgjarrett mgjarrett marked this pull request as ready for review September 16, 2024 17:48
@mgjarrett mgjarrett merged commit 0b3c7c1 into main Sep 16, 2024
15 checks passed
@mgjarrett mgjarrett deleted the updateFluidVolume_axExp branch September 16, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants