-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fluid volumes after prescribed axial expansion #1828
Conversation
Co-authored-by: Michael Jarrett <mjarrett@terrapower.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Easy enough!
Being picky, if you could update the "what is the change" section of the PR, that may be nice. Could be a simple "clear the cached volume for fluid components in order for them to be updated post axial expansion. ensures consistency with the parent block height and that total assembly fluid mass is conserved".
Converting this to draft until it's ready to be merged -- we have downstream testing that we need to do before this can be merged. Once said testing is done, we will crack this back open for merging! |
What is the change?
Clear the cached volume for fluid components in order for them to be updated post axial expansion. Ensures consistency with the parent block height and that total assembly fluid mass is conserved
Why is the change being made?
After prescribed axial expansion is applied to a block, the cache should be cleared from all components so that the component volume can be recalculated based on the new block height. It was only being done for solid components, which left fluid components in a state where their volume was not consistent with their parent block's height.
Checklist
doc
folder.pyproject.toml
.