Fix interactive versus batch mode check #1786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
For determining if the current mode is batch or interactive, there is an
isatty()
check performed. This check worked properly on windows, but for some reason not on a linux cluster. It appearsstdout
works for windows andstdin
works for linux but not vice versa. So I added an os-specific check.Why is the change being made?
The hack that was made didn't work for cases with 1 task. This update works on both clusters, and removes a little hack we had put in place.
Checklist
doc
folder.pyproject.toml
.