Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interactive versus batch mode check #1786

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Fix interactive versus batch mode check #1786

merged 3 commits into from
Jul 18, 2024

Conversation

opotowsky
Copy link
Member

@opotowsky opotowsky commented Jul 18, 2024

What is the change?

For determining if the current mode is batch or interactive, there is an isatty() check performed. This check worked properly on windows, but for some reason not on a linux cluster. It appears stdout works for windows and stdin works for linux but not vice versa. So I added an os-specific check.

Why is the change being made?

The hack that was made didn't work for cases with 1 task. This update works on both clusters, and removes a little hack we had put in place.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@opotowsky opotowsky added the bug Something is wrong: Highest Priority label Jul 18, 2024
@john-science john-science self-requested a review July 18, 2024 20:26
@john-science john-science merged commit b1f88d7 into main Jul 18, 2024
14 checks passed
@john-science john-science deleted the fix-isatty branch July 18, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants