Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the unused method Case.buildCommand #1773

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Removing the unused method Case.buildCommand #1773

merged 2 commits into from
Jul 18, 2024

Conversation

john-science
Copy link
Member

What is the change?

Removing the unused method Case.buildCommand().

Why is the change being made?

To close #1772 , but also this method just is not generally useful enough to be in ARMI.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Jul 11, 2024
@john-science john-science requested a review from opotowsky July 11, 2024 16:20
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll come merge this once the downstream update is in place. Thanks!

@opotowsky opotowsky merged commit 1c6eadb into main Jul 18, 2024
19 checks passed
@opotowsky opotowsky deleted the rm_build_cmd branch July 18, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildCommand only works on windows and probably doesn't belong in ARMI
2 participants