Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations and refactoring in mesh and cccc #174

Merged
merged 11 commits into from
Oct 12, 2020

Commits on Oct 9, 2020

  1. Optimizations and refactoring in mesh and cccc

    * Add a implicit-typed list reader to CCCC utils since we have 3
      implementations, and growing
    
    * Make CCCC file names into module-level constants to reduce strings
    
    * Reduce pointless mesh computations during reactor init
    
    * Promote coverage to main requirements file since it is required if you
      activate the framework "coverage" setting.
    ntouran committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    208463e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b9766d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b191090 View commit details
    Browse the repository at this point in the history
  4. Attempt to reduce noise/signal in cccc readers

    This is another step towards a better cccc submodule.
    
    * Put all cccc modules in new subpackage for clarity about what's cccc
    
    * Added more docs and examples
    
    This did not go so far as to add a consistent public interface on all
    cccc DataContainers so users don't have to use the streams.
    ntouran committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    4f40c0b View commit details
    Browse the repository at this point in the history
  5. Code review comments

    ntouran committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    3c10af4 View commit details
    Browse the repository at this point in the history
  6. Add NHFLUX writing unit test

    ntouran committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    61c6340 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    91afee3 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Comment fixes

    ntouran committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    bba29bb View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. Configuration menu
    Copy the full SHA
    7ec2cad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4efe0d2 View commit details
    Browse the repository at this point in the history
  3. Change CCCC rwList to return ndarray

    This makes all non-scalar CCCC data ndarrays for consistency.
    
    Also updated new NhfluxStreams to deal with VARIANT options.
    ntouran committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    af578a7 View commit details
    Browse the repository at this point in the history