Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing outsideFuelRing parameters #1700

Merged
merged 4 commits into from
May 16, 2024
Merged

Removing outsideFuelRing parameters #1700

merged 4 commits into from
May 16, 2024

Conversation

john-science
Copy link
Member

What is the change?

Removing two parameters: outsideFuelRing and outsideFuelRingFluxFr.

Why is the change being made?

After some discussion, we decided these parameters were unused.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label May 14, 2024
@john-science john-science requested review from mgjarrett and onufer May 14, 2024 16:23
@john-science
Copy link
Member Author

FYI, these stupid Windows tests failures are happening everywhere in ARMI now. Even in the main branch.

I am trying to fix it separately.

@john-science john-science merged commit 872e2da into main May 16, 2024
21 checks passed
@john-science john-science deleted the rm_outsideFuelRing branch May 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onufer onufer onufer approved these changes

@mgjarrett mgjarrett Awaiting requested review from mgjarrett

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @onufer