Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving .coveragerc info into pyproject.toml #1692

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Conversation

john-science
Copy link
Member

What is the change?

I removed the .coveragerc file and adding that configuration into the pyproject.toml.

Why is the change being made?

Since we have moved the ARMI project to using pyproject.toml for everything else, it makes sense to do it also for this last feature. And it is the community standard these days.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added cleanup Code/comment cleanup: Low Priority ci Related to continuous integration / github actions labels Apr 19, 2024
@john-science john-science requested a review from opotowsky April 19, 2024 23:55
@john-science john-science linked an issue Apr 19, 2024 that may be closed by this pull request
@john-science
Copy link
Member Author

DO NOT MERGE

I want to do some careful by-line testing to make sure all the rules translated correctly to the new format.

@opotowsky
Copy link
Member

DO NOT MERGE

I want to do some careful by-line testing to make sure all the rules translated correctly to the new format.

Feel free to re-request a review if you make big changes after testing. Looks good to me though!

@john-science
Copy link
Member Author

Okay, the coverage results match, so this PR is safe to merge.

@john-science john-science merged commit dbdeb99 into main Apr 22, 2024
21 checks passed
@john-science john-science deleted the coverage_2_pyproj branch April 22, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration / github actions cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move .coveragerc file into pyproject.toml
2 participants