Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding system info logging for Linux #1689

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Adding system info logging for Linux #1689

merged 9 commits into from
Apr 22, 2024

Conversation

john-science
Copy link
Member

What is the change?

Adding detailed system information for OS and processors, for a wide range of Linux operating systems.

Because there are so many different flavors of Linux, the new system info logging has multiple redundant ways to find the same OS/processor information. The code will try each one in turn before giving up and trying the next one. In this way, we should support a wide array of Linux flavors seamlessly.

Why is the change being made?

ARMI is supposed to support Windows and Linux.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the feature request Smaller user request label Apr 18, 2024
@john-science john-science requested a review from opotowsky April 18, 2024 18:45
opotowsky
opotowsky reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll want to test this internally too given the runLog nature of the update. But great work!

armi/bookkeeping/report/reportingUtils.py Outdated Show resolved Hide resolved
armi/bookkeeping/report/tests/test_report.py Outdated Show resolved Hide resolved
@john-science @opotowsky
Apply suggestions from code review
b38818d 
Co-authored-by: Arrielle Opotowsky <arrielle.opotowsky@gmail.com>
@john-science john-science requested a review from opotowsky April 19, 2024 22:41
opotowsky
opotowsky approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested as expected!

@john-science john-science changed the title Adding sysrtem info logging for Linux Adding system info logging for Linux Apr 22, 2024
opotowsky
opotowsky approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of the getNodeName update!

@john-science @opotowsky
Update armi/bookkeeping/report/reportingUtils.py
4870ae4 
Co-authored-by: Arrielle Opotowsky <arrielle.opotowsky@gmail.com>
@john-science john-science linked an issue Apr 22, 2024 that may be closed by this pull request
Add sysinfo for linux #1684
Closed
@opotowsky opotowsky merged commit 33e3a88 into terrapower:main Apr 22, 2024
11 checks passed
@john-science john-science deleted the linux_sysinfo branch April 22, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
feature request Smaller user request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sysinfo for linux
2 participants
@john-science @opotowsky