Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ruff check to the GH Actions #1419

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Adding ruff check to the GH Actions #1419

merged 3 commits into from
Oct 2, 2023

Conversation

john-science
Copy link
Member

What is the change?

Here I add an extra GitHub CI check: ruff.

Why is the change being made?

ARMI has unofficially been under ruff linting for over three months. It's time to make ruff formatting in ARMI mandatory.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the enhancement New feature or request label Sep 29, 2023
@john-science
Copy link
Member Author

@drewj-usnctech @sombrereau @keckler @mgjarrett Just FYI. Tell yer friends.

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve!

@john-science john-science merged commit b76b75e into main Oct 2, 2023
@john-science john-science deleted the ruff_gh_action branch October 2, 2023 15:12
albeanth pushed a commit to albeanth/armi that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants