Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to black v22.6 #1396

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Update to black v22.6 #1396

merged 3 commits into from
Aug 30, 2023

Conversation

opotowsky
Copy link
Member

@opotowsky opotowsky commented Aug 30, 2023

What is the change?

Updating to a more modern, but not totally modern, version of black for autoformatting expectations

Why is the change being made?

We are using a pre-release quite old version of black, v20.8b1. This has led to the need to version pin click as well. So updating to v22.6 brings us closer to the present while also allowing us to un-pin click. This is 100% whitespace updates so it should be a quick review.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@opotowsky opotowsky requested a review from john-science August 30, 2023 17:04
@opotowsky opotowsky added the ci Related to continuous integration / github actions label Aug 30, 2023
setup.py Outdated Show resolved Hide resolved
@john-science john-science merged commit 4923e99 into main Aug 30, 2023
@john-science john-science deleted the black branch August 30, 2023 17:59
drewj-usnctech added a commit to drewj-usnctech/armi that referenced this pull request Sep 6, 2023
…t-mod-empty-validation

* terrapower/main: (23 commits)
  Allowing users to set powerDensity instead of power (terrapower#1395)
  Fix assemNum parameter for uniform mesh reactor. (terrapower#1398)
  Update to black v22.6.0 (terrapower#1396)
  Fixing gallery example for new working Grids (terrapower#1394)
  Refactor armi.reactor.grids to wider submodule; Grids as ABC (terrapower#1373)
  Make SFP a child of reactor. (terrapower#1349)
  Move max assembly number out of global scope (terrapower#1383)
  Ensuring we throw an error on bad YAML files (terrapower#1358)
  Removing unused settings (terrapower#1393)
  Fixing some miscellaneous TODOs (terrapower#1392)
  Removing global plugin flags (terrapower#1388)
  Update reactivity coefficient parameters (terrapower#1355)
  Fixing ruff formatting of doc gallery examples (terrapower#1389)
  Fixing broken link (terrapower#1390)
  Removing unreachable code block (terrapower#1391)
  Removing unnecessary f-strings (terrapower#1387)
  Updating documentation dependencies for Python 3.11 (terrapower#1378)
  Adding a little code coverage to the CLIs (terrapower#1371)
  Remove coveragepy-lcov dependency during CI. (terrapower#1382)
  Reconnect logger after disconnecting in test. (terrapower#1381)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration / github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants