Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing global variable from runLog.py #1370

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Removing global variable from runLog.py #1370

merged 1 commit into from
Aug 1, 2023

Conversation

john-science
Copy link
Member

What is the change?

I removed the global _WHITE_SPACE variable from runLog.py.

Why is the change being made?

Other than getting rid of an ugly global variable, I was responding to this dicussion, started by Arrielle. Good call!

Checklist

  • This PR has only one purpose or idea. (For real this time.)
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Aug 1, 2023
@john-science john-science requested a review from opotowsky August 1, 2023 21:46
opotowsky
opotowsky approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for taking this on so quickly.

Just a sanity check: this line gives a "default" for the global variable (_WHITE_SPACE = " " * 6), but that was never used, correct?

@john-science
Copy link
Member Author

Just a sanity check: this line gives a "default" for the global variable (_WHITE_SPACE = " " * 6), but that was never used, correct?

That was never used directly. But it turns out that's the value that gets calculated for nearly all cases in the MPI_RANK=0 parent process.

@john-science john-science merged commit e8ddcdf into main Aug 1, 2023
@john-science john-science deleted the rm_global_from_runlog branch August 1, 2023 22:19
drewj-usnctech added a commit to drewj-usnctech/armi that referenced this pull request Aug 24, 2023
@drewj-usnctech
Merge remote-tracking branch 'terrapower/main' into drewj-usnctech/gr…
df4bfa4 
…id-refactor-pre-1278

* terrapower/main:
  Move max assembly number out of global scope (terrapower#1383)
  Ensuring we throw an error on bad YAML files (terrapower#1358)
  Removing unused settings (terrapower#1393)
  Fixing some miscellaneous TODOs (terrapower#1392)
  Removing global plugin flags (terrapower#1388)
  Update reactivity coefficient parameters (terrapower#1355)
  Fixing ruff formatting of doc gallery examples (terrapower#1389)
  Fixing broken link (terrapower#1390)
  Removing unreachable code block (terrapower#1391)
  Removing unnecessary f-strings (terrapower#1387)
  Updating documentation dependencies for Python 3.11 (terrapower#1378)
  Adding a little code coverage to the CLIs (terrapower#1371)
  Remove coveragepy-lcov dependency during CI. (terrapower#1382)
  Reconnect logger after disconnecting in test. (terrapower#1381)
  Add Python 3.11 to GH Actions (terrapower#1341)
  Removing global variable from runLog.py (terrapower#1370)
  Moving the First-Time Contributors guide to the docs (terrapower#1368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @opotowsky