-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nucTempHelper to CylindricalComponentsAverageBlockCollection #1363
Add nucTempHelper to CylindricalComponentsAverageBlockCollection #1363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
At first I thought that the 1D slab class would need a similar _getNucTempHelper
method. But looking at that class, it seems like it is hard-coded to only ever work for isothermal reactors, so such an averaging process isn't needed. Is that your assessment as well?
@@ -295,6 +295,8 @@ def test_ComponentAverage1DCylinder(self): | |||
|
|||
xsgm.interactBOL() | |||
|
|||
xsgm.updateNuclideTemperatures() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is just a check to see that the NotImplementedError
doesn't arise? Not sure if it's easy to add more to this test?
Yeah, the fact that it explicitly raises a |
Is there something blocking this from being merged? It is a feature that I think is needed for our current analyses and its been sitting up here for months now. I have been manually pulling this branch into my installation because I need it, so it'd be great if we can just merge it. |
@keckler it's dependent on a larger downstream PR. It should get merged soon. |
What is the change?
This PR adds a
_getNucTempHelper
method toCylindricalComponentsAverageBlockCollection
Why is the change being made?
The
CylindricalComponentsAverageBlockCollection
was implemented recently: #1238It needs to have a
_getNucTempHelper
method like some of the other block collections, e.g., theAverageBlockCollection
, in order to perform downstream analyses that require this method.Checklist
doc/release/0.X.rst
) are up-to-date with any important changes.doc
folder.setup.py
.