Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nucTempHelper to CylindricalComponentsAverageBlockCollection #1363

Merged
merged 10 commits into from
Oct 25, 2023

Conversation

mgjarrett
Copy link
Contributor

@mgjarrett mgjarrett commented Jul 26, 2023

What is the change?

This PR adds a _getNucTempHelper method to CylindricalComponentsAverageBlockCollection

Why is the change being made?

The CylindricalComponentsAverageBlockCollection was implemented recently: #1238

It needs to have a _getNucTempHelper method like some of the other block collections, e.g., the AverageBlockCollection, in order to perform downstream analyses that require this method.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@keckler keckler self-requested a review August 11, 2023 18:03
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

At first I thought that the 1D slab class would need a similar _getNucTempHelper method. But looking at that class, it seems like it is hard-coded to only ever work for isothermal reactors, so such an averaging process isn't needed. Is that your assessment as well?

@@ -295,6 +295,8 @@ def test_ComponentAverage1DCylinder(self):

xsgm.interactBOL()

xsgm.updateNuclideTemperatures()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is just a check to see that the NotImplementedError doesn't arise? Not sure if it's easy to add more to this test?

@mgjarrett
Copy link
Contributor Author

This looks good.

At first I thought that the 1D slab class would need a similar _getNucTempHelper method. But looking at that class, it seems like it is hard-coded to only ever work for isothermal reactors, so such an averaging process isn't needed. Is that your assessment as well?

Yeah, the fact that it explicitly raises a NotImplementedError for _getNucTempHelper even though it inherits the same thing from BlockCollection makes me think that somebody really doesn't want it to be implemented. I don't think it would be harmful to implement one, but there's also no apparent need for it, so I'm happy to just maintain status quo here.

@keckler
Copy link
Member

keckler commented Sep 29, 2023

Is there something blocking this from being merged? It is a feature that I think is needed for our current analyses and its been sitting up here for months now. I have been manually pulling this branch into my installation because I need it, so it'd be great if we can just merge it.

@albeanth
Copy link
Member

albeanth commented Oct 4, 2023

@keckler it's dependent on a larger downstream PR. It should get merged soon.

@mgjarrett mgjarrett marked this pull request as ready for review October 25, 2023 15:27
@mgjarrett mgjarrett merged commit 753660d into terrapower:main Oct 25, 2023
11 checks passed
@mgjarrett mgjarrett deleted the nucTempHelper_Cylindrical branch October 25, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants