Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving HexBlock getWettedPerimeter calculation #1299

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Improving HexBlock getWettedPerimeter calculation #1299

merged 6 commits into from
Jun 12, 2023

Conversation

john-science
Copy link
Member

@john-science john-science commented Jun 9, 2023 •
edited
Loading

Description

Improving HexBlock getWettedPerimeter calculation to include wire wrap

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added the bug Something is wrong: Highest Priority label Jun 9, 2023
@john-science john-science requested a review from opotowsky June 9, 2023 16:36
@john-science john-science linked an issue Jun 9, 2023 that may be closed by this pull request
Correct the wetted perimeter calculation in blocks.py #1297
Closed
dlangewisch
dlangewisch reviewed Jun 9, 2023
View reviewed changes
armi/reactor/blocks.py Outdated Show resolved Hide resolved
@john-science john-science requested a review from dlangewisch June 9, 2023 22:16
dlangewisch
dlangewisch approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@dlangewisch dlangewisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct.

opotowsky
opotowsky approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving purely from a code perspective, since Dustin approved the technical correctness for us :-)

@opotowsky opotowsky merged commit b66c4dc into main Jun 12, 2023
@opotowsky opotowsky deleted the wetted_perimeter branch June 12, 2023 14:33
drewj-usnctech added a commit to drewj-usnctech/armi that referenced this pull request Jun 12, 2023
@drewj-usnctech
Merge remote-tracking branch 'terrapower/main' into drewj-usnctech/le…
1d974ec 
…ss-iter-components

* terrapower/main:
  Improving HexBlock getWettedPerimeter calculation (terrapower#1299)
  Sort components on representative block. (terrapower#1275)
  Unifying the Reactor sorting (terrapower#1280)
  Building helper tool for when Parameters need to be NumPy arrays (terrapower#1292)
  Apply decusping to individual assemblies. (terrapower#1282)
  Block collection burnup (terrapower#1265)
  Cleaning up TODOs (terrapower#1291)
  Docstring Improvements - linting (terrapower#1287)
  Adding the word Important, per user request (terrapower#1289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlangewisch dlangewisch dlangewisch approved these changes

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct the wetted perimeter calculation in blocks.py
3 participants
@john-science @opotowsky @dlangewisch