-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving from pylint to ruff linter #1296
Conversation
Every time you merge |
Ok I've started clicking view on files. Finally in progress! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this PR looks good! I've also testing things internally and nothing has changed.
Nice work yet again, @john-science
Description
This PR moves the ARMI project from using the
pylint
linter to using theruff
linter.That means that this PR is big, because we used to have
# pylint: disable=xyz
lines in like every Python file. But that's not necessary withruff
. Not only isruff
like 100x faster, it is easier to configure (see the top-levelruff.toml
file I added).Also, this PR fixes all
ruff
errors in the repo. This allows me to add a new GitHub Action just to runruff
on the code, like we do when we runblack
. This way we can prevent people from adding poorly formatted code to the repo.Also,
ruff
has the MIT license, which is a big improvement overpylint
.Checklist
doc/release/0.X.rst
) are up-to-date with any important changes.doc
folder.setup.py
.