Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XSGM interface stack position to just before before MC2 #1288

Merged
merged 10 commits into from
Jun 14, 2023

Conversation

HunterPSmith
Copy link
Contributor

@HunterPSmith HunterPSmith commented Jun 1, 2023

Description

The cross section group manager is currently called before depletion and fuel management in the interface stack. Therefore, any changes due to burnup are not accounted for when cross sections are generated.

This was historically done to support branch searching. It is also necessary to enable flux-weighted representative blocks, as several blocks will have 0 flux after fuel shuffling, so the implementation of this PR will mean that we can no longer support this.

This PR moves the cross section group manager interface in the interface stack to just before mc2. Also sets the default cross section block averaging method to Average instead of FluxWeightedAverage.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works. NOTE: PR 1308 has an additional test to support this PR.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@albeanth
Copy link
Member

albeanth commented Jun 1, 2023

@keckler do you recall which issue you opened that discussed this? We should link that here for posterity. I tried looking for it but couldn't find it.

@keckler
Copy link
Member

keckler commented Jun 1, 2023

#839

Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment here. Thanks @HunterPSmith

Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment here. Thanks @HunterPSmith

Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage drop is addressed in #1308.

@albeanth albeanth marked this pull request as ready for review June 14, 2023 18:11
@john-science john-science added the feature request Smaller user request label Jun 14, 2023
@john-science
Copy link
Member

@albeanth Wants us to connect this PR to #1308

Essentially, that PR exists to increase code coverage that this PR drops. (Since Tony does not have the power to change this PR as it originates in a private repo.)

@albeanth
Copy link
Member

Since Tony does not have the power to change this PR as it originates in a private repo.

Turns out I do, but I didn't find that out until after I created #1308. So instead of closing #1308 and cherry-picking over the commits or merging the feature branch to this PR, I just left everything as is....

But good to know I have some power for the future! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap the ordering of the XS group manager and fuel handler in the interface stack
5 participants