-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change XSGM interface stack position to just before before MC2 #1288
Change XSGM interface stack position to just before before MC2 #1288
Conversation
@keckler do you recall which issue you opened that discussed this? We should link that here for posterity. I tried looking for it but couldn't find it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment here. Thanks @HunterPSmith
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment here. Thanks @HunterPSmith
…terfaceStackSwitch
This reverts commit 62b5748.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage drop is addressed in #1308.
Turns out I do, but I didn't find that out until after I created #1308. So instead of closing #1308 and cherry-picking over the commits or merging the feature branch to this PR, I just left everything as is.... But good to know I have some power for the future! 😄 |
Description
The cross section group manager is currently called before depletion and fuel management in the interface stack. Therefore, any changes due to burnup are not accounted for when cross sections are generated.
This was historically done to support branch searching. It is also necessary to enable flux-weighted representative blocks, as several blocks will have 0 flux after fuel shuffling, so the implementation of this PR will mean that we can no longer support this.
This PR moves the cross section group manager interface in the interface stack to just before mc2. Also sets the default cross section block averaging method to
Average
instead ofFluxWeightedAverage
.Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.