-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding axial expansion support for CRAs #1226
Conversation
- for just upward expansion, we can utilize the existing axial expansion methodology. - thermal expansion of a prototypical CRA has been hand checked to verify the validity of post thermal expansion block heights. I.e., the expanded block heights are logical given the original cold block height.s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy enough. You need to add something to the changelog. I imagine this might change some results and confuse people.
Coverage drop appears to be coverage spray.... |
@albeanth This is waiting on a downstream project. So, short-term holding pattern. |
This PR is ready, but I am converting to draft while we figure out downstream merge dependencies. |
Description
This PR adds support for axial expansion of pin-type control rod assemblies (CRAs). The primary assumption with this approach is that all components axially expand upwards. This is a valid assumption as long as the z-elevation of the control bundle tip is relative to itself; i.e., simply placing the bundle at a prescribed z-elevation. This is in contrast to the case where the z-elevation of the control bundle is relative to the control rod driveline. In this case, the downward expansion of components within the control bundle becomes important and this approach is invalidated.
This PR will remain in draft state until 1) unit tests are added to support CRA expansion, and 2) the effects on downstream applications have been quantified.
Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.