Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding axial expansion support for CRAs #1226

Merged
merged 10 commits into from
Apr 25, 2023
Merged

Conversation

albeanth
Copy link
Member

@albeanth albeanth commented Mar 28, 2023

Description

This PR adds support for axial expansion of pin-type control rod assemblies (CRAs). The primary assumption with this approach is that all components axially expand upwards. This is a valid assumption as long as the z-elevation of the control bundle tip is relative to itself; i.e., simply placing the bundle at a prescribed z-elevation. This is in contrast to the case where the z-elevation of the control bundle is relative to the control rod driveline. In this case, the downward expansion of components within the control bundle becomes important and this approach is invalidated.

This PR will remain in draft state until 1) unit tests are added to support CRA expansion, and 2) the effects on downstream applications have been quantified.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

- for just upward expansion, we can utilize the existing axial expansion methodology.
- thermal expansion of a prototypical CRA has been hand checked to verify the validity of post thermal expansion block heights. I.e., the expanded block heights are logical given the original cold block height.s
@albeanth albeanth marked this pull request as ready for review March 31, 2023 22:30
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough. You need to add something to the changelog. I imagine this might change some results and confuse people.

@albeanth albeanth requested a review from keckler April 3, 2023 19:33
@albeanth
Copy link
Member Author

albeanth commented Apr 4, 2023

Coverage drop appears to be coverage spray....

@john-science
Copy link
Member

@albeanth This is waiting on a downstream project. So, short-term holding pattern.

@albeanth albeanth marked this pull request as draft April 19, 2023 22:28
@albeanth
Copy link
Member Author

This PR is ready, but I am converting to draft while we figure out downstream merge dependencies.

@albeanth albeanth marked this pull request as ready for review April 25, 2023 14:42
@albeanth albeanth merged commit 0990288 into terrapower:main Apr 25, 2023
@albeanth albeanth deleted the CRA_AxExp branch April 25, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants