Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports to method to avoid circular import issue #1185

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

opotowsky
Copy link
Member

@opotowsky opotowsky commented Feb 15, 2023

Description

This import caused a circular import that was hidden for a lot of us, partially because so many unit tests call armi.configure() (or app of choice) or because case runs already have an application configured. Thanks to @alexhjames for finding this and being patient while we figured it out!

This resolves the issue found in #1184, but I don't think it resolves the issue itself, since it is broader than this little fix.

I do not believe this is unit testable; willing to be proven wrong.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@opotowsky opotowsky added the bug Something is wrong: Highest Priority label Feb 15, 2023
@john-science john-science merged commit ca8ad39 into terrapower:main Feb 15, 2023
@john-science john-science deleted the circle branch February 15, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants