Fix user plugins case suite #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the submission of cases, userPlugins are registered. This can result in multiple attempts to load a specific userPlugin if a case-suite is being submitted, as each loading of the input yaml attempts to register the userPlugin. A check has been added to skip the registration of the userPlugin if a userPlugin with the same name already exists in the registry.
|
Somehow I have never run into this issue... I wonder what is different between your case suite and mine. |
john-science
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When submitting a
case-suitethat usesuserPlugins, registration of theuserPluginwith the plugin manager is attempted multiple times. The plugin manager does not allow this, and thecase-suitefails.To fix this, the registration of
userPlugins now checks if the user plugin name has already been registered with the plugin manager.Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.