Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching the Magnesium density curve to match the reference #1126

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

john-science
Copy link
Member

Description

Based on a discussion here with @dpham-materials, it appears our Magnesium density curve very slightly mis-matched the provided reference.

It is a very slight difference, but since there is no other reference provided, I am just going to fix it.

@opotowsky It will be up to us to determine if any downstream projects/integration tests actually USE this material. If not, it's easy. If so, we will have to determine how this change affects our project results.

This PR is part of this umbrella ticket.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added the bug Something is wrong: Highest Priority label Jan 26, 2023
@opotowsky
Copy link
Member

I can kick off tests internally

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has no downstream impacts as far as my testing shows.

@john-science john-science merged commit 0e8140b into main Jan 26, 2023
@john-science john-science deleted the mg_density_fix branch January 26, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants