Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some gallery examples are broken #417

Closed
mgjarrett opened this issue Sep 20, 2021 · 2 comments
Closed

Some gallery examples are broken #417

mgjarrett opened this issue Sep 20, 2021 · 2 comments
Assignees
Labels
bug Something is wrong: Highest Priority documentation Improvements or additions to documentation

Comments

@mgjarrett
Copy link
Contributor

mgjarrett commented Sep 20, 2021

Six of the gallery examples show a "broken" thumbnail.

https://terrapower.github.io/armi/gallery/index.html

Related to #394; some of these examples are calling a sefl._log() with arguments that are consistent with the ARMI logger where a standard python logger is expected.

Traceback (most recent call last):
  File "/home/runner/work/armi/armi/doc/gallery-src/framework/run_fuelManagement.py", line 31, in <module>
    o, reactor = test_reactors.loadTestReactor(inputFileName="refTestCartesian.yaml")
  File "/home/runner/work/armi/armi/armi/reactor/tests/test_reactors.py", line 176, in loadTestReactor
    o = operators.factory(cs)
  File "/home/runner/work/armi/armi/armi/operators/__init__.py", line 52, in factory
    return getOperatorClassFromSettings(cs)(cs)
  File "/home/runner/work/armi/armi/armi/operators/operator.py", line 110, in __init__
    reportingUtils.writeWelcomeHeaders(self, cs)
  File "/home/runner/work/armi/armi/armi/bookkeeping/report/reportingUtils.py", line 201, in writeWelcomeHeaders
    _writeCaseInformation(o, cs)
  File "/home/runner/work/armi/armi/armi/bookkeeping/report/reportingUtils.py", line 85, in _writeCaseInformation
    runLog.header("=========== Case Information ===========")
  File "/home/runner/work/armi/armi/armi/runLog.py", line 384, in header
    LOG.log("header", msg, single=single, label=label)
  File "/home/runner/work/armi/armi/armi/runLog.py", line 163, in log
    self.logger.log(msgLevel, msg, single=single, label=label)
  File "/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/logging/__init__.py", line 1512, in log
    self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'single'
@john-science john-science self-assigned this Sep 20, 2021
@john-science john-science added bug Something is wrong: Highest Priority documentation Improvements or additions to documentation labels Sep 20, 2021
john-science added a commit to john-science/armi that referenced this issue Sep 20, 2021
@john-science
Copy link
Member

@mgjarrett I opened a PR for this: #418

youngmit pushed a commit that referenced this issue Sep 24, 2021
* #417 fixed 5 of the 6 gallery images

* Fail the build if you break the docs

* Inserting a default thumbnail for the MCNP example

* We have unit tests for import resolution issues
@john-science
Copy link
Member

PR #418 resolved this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants