Add optimization: Extract sub-expressions in join conditions to value slots #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, NQuery already optimized "trivial case" joins very nicely, such as this one:
Regardless of
<type>
, these queries used aHashMatchIterator
. Unfortunately, even simple changes makes it fall back to nested loops:Bummer, as adding a simple conversion kills performance of big queries.
The proposed additional optimization step extracts computations in join conditions into dedicated value slots (if beneficial) to enable the already existing other optimizations. It even works with contrived examples such as this one:
Not modified are conjunctions with any operator other than
=
as well as sides that refer to both input relations (e.g.e.EmployeeID - et.EmployeeID = 0
).