Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add App Service Environment resource and Data Source #5508

Merged
merged 26 commits into from
Feb 23, 2020

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Jan 24, 2020

Adds new resource and datasource for App Service Environment (v2 support only)

Replaces #4956

Co-authored-by: @justinbarias

Fixes #438

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments inline (which I've pushed some commits to fix, as discussed) but this mostly LGTM 👍

azurerm/internal/services/network/virtual_network.go Outdated Show resolved Hide resolved
azurerm/internal/services/network/subnet.go Outdated Show resolved Hide resolved
azurerm/internal/services/network/virtual_network.go Outdated Show resolved Hide resolved
azurerm/internal/services/network/subnet.go Outdated Show resolved Hide resolved
azurerm/internal/services/network/subnet.go Outdated Show resolved Hide resolved
website/docs/r/app_service_environment.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_service_environment.html.markdown Outdated Show resolved Hide resolved
website/docs/r/app_service_environment.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments inline (which I've pushed some commits to fix, as discussed) but this mostly LGTM 👍

@tombuildsstuff tombuildsstuff force-pushed the f/app-service-environment-v2 branch 3 times, most recently from eaee0f2 to 986f9c3 Compare February 21, 2020 17:58
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-02-23 at 15 21 53

@tombuildsstuff tombuildsstuff merged commit 59c704d into master Feb 23, 2020
@tombuildsstuff tombuildsstuff deleted the f/app-service-environment-v2 branch February 23, 2020 17:47
tombuildsstuff added a commit that referenced this pull request Feb 23, 2020
@midacts
Copy link
Contributor

midacts commented Feb 23, 2020

Awesome job. Thanks for adding this.

@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: AppService Environments (ASE) Support
4 participants