Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: app_service_environment #4956

Closed

Conversation

justinbarias
Copy link
Contributor

@justinbarias justinbarias commented Nov 22, 2019

Hi @tombuildsstuff

This is a continuation of your old WIP PR ASE PR.

Started the work off your old branch app-service-environment.

To do:

  • Simple integration test
  • Complete Integration Test suite
  • Revisit schema (maybe include keyvault setting for the internal cert configuration?)
  • Docs

Open to hear your thoughts. So far - i've tested it using the simple e2e test, and by copying the binary to an actual TF project, seems to work well - the new app service environment APIs look good.

Some of my findings on the new API version - there seems to be inconsistencies with the values returned for the frontEndPool SKUs - it doesn't exactly follow the enums defined in the model so i had to do a hacky conversion method.

Cheers
Justin

@ghost ghost added the size/XL label Nov 22, 2019
@ghost ghost added dependencies size/XXL and removed size/XL labels Nov 22, 2019
@tombuildsstuff tombuildsstuff added this to the v2.0.0 milestone Nov 28, 2019
@jackofallops
Copy link
Member

hey @justinbarias
Thanks for picking up this Pull Request - since both App Service Environments and the codebase have changed substantially since the original PR was opened, we've spent some time trying to work out how to proceed with this PR.
When the original App Service Environment PR was opened we looked to support ASEv1's - but during the time the 2019-08-01 API's been broken, and ASEv2's have become preferred over v1. As such whilst we appreciate this contribution, I hope you don't mind but in order to be able to get this shipped I'm going to pull these changes into a local branch (I will add you as a co-author) and close this PR for the moment - in the near future I'll open a PR containing the changes mentioned above (which I'm working on at the moment).
Thanks!

-Ste

jackofallops added a commit that referenced this pull request Jan 24, 2020
jackofallops added a commit that referenced this pull request Feb 12, 2020
tombuildsstuff pushed a commit that referenced this pull request Feb 19, 2020
tombuildsstuff pushed a commit that referenced this pull request Feb 20, 2020
tombuildsstuff pushed a commit that referenced this pull request Feb 21, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants