Add support for SES MAIL FROM

[mintuhouse]

https://docs.aws.amazon.com/ses/latest/DeveloperGuide/mail-from-set.html

Would be the last missing piece after #1347

[petergoldstein]

@Ninir @radeksimko Is there anything that needs to be done to push this across the finish line?

[madmod]

If this needs anything else done I'm willing to take it on.

[bflad]

I'll be taking a look at this later today.

[bflad]

Thanks for this contribution! 😄 I think this is off to a great start! I left some comments below. Can you please look through them and let me know if you have any questions or if you do not have time to implement them? Thanks!

[bflad]

We should not need ForceNew: true here since be able to support updates by calling SetIdentityMailFromDomain just like create. 😄

[bflad]

Two things here:

• Nitpick: SDK has a constant available ses.BehaviorOnMXFailureUseDefaultValue
• Seems easy enough to support this as an optional attribute, that defaults to this

[bflad]

We should really be resetting the mail_from_domain attribute in the Terraform state each read to catch drift from the Terraform configuration, e.g.

out, err := conn.GetIdentityMailFromDomainAttributes(readOpts)
if err != nil {
	log.Printf("[WARN] Error fetching MAIL FROM domain attributes for %s: %s", d.Id(), err)
	return err
}

if v, ok := out.MailFromDomainAttributes[domainName]; ok {
	d.Set("mail_from_domain", v.MailFromDomain)
} else {
	d.Set("mail_from_domain", "")
}

[bflad]

Nitpick: this parameter is not required here

[bflad]

Nitpick: We should use d.Id()

[bflad]

Can you please implement a CheckDestroy: function for the TestCase? This is one final check in our acceptance tests to verify that the delete/destroy actually did what it was supposed to in AWS. e.g.

func testAccCheckSESDomainMailFromDestroy(s *terraform.State) error {
	conn := testAccProvider.Meta().(*AWSClient).sesConn

	for _, rs := range s.RootModule().Resources {
		if rs.Type != "aws_ses_domain_mail_from" {
			continue
		}

		input := &ses.GetIdentityMailFromDomainAttributesInput{
			Identities: []*string{aws.String(rs.Primary.ID)},
		}

		out, err := conn.GetIdentityMailFromDomainAttributes(input)
		if err != nil {
			return fmt.Errorf("error fetching MAIL FROM domain attributes: %s", err)
		}
		if v, ok := out.MailFromDomainAttributes[domainName]; ok && len(v.MailFromDomain) > 0 {
			return fmt.Errorf("MAIL FROM domain was not removed, found: %s", v.MailFromDomain)
		}
	}

	return nil
}

[bflad]

Copypasta 🍝 : should be aws_ses_domain_mail_from (backslashes are no longer required in the documentation)

[bflad]

Nitpick: We generally keep the example usage above arguments.

[bflad]

Feel free to point these at a "fake" resource to encourage proper references, e.g. ${aws_route53_zone.example.id}

[bflad]

Nitpick: I think we should cross-reference either the ${aws_ses_domain_mail_from.example.mail_from_domain} here or ${aws_route53_record. example_amazonses_mail_from_mx_record.name} in aws_ses_domain_mail_from to better show the linkage between the two

[bflad]

Sorry I forgot to mention in the initial review -- we should verify the attributes are set correctly in the Terraform state as well 👍 e.g.

resource.TestCheckResourceAttr("aws_ses_domain_mail_from.test", "domain", domain),
resource.TestCheckResourceAttr("aws_ses_domain_mail_from.test", "mail_from_domain", fmt.Sprintf("bounce.%s", domain)),

[mintuhouse]

@bflad The project where I originally used this code is no longer active and changed PC since then.
I will have to refresh my go and terraform (which was super easy to pick up by the way 👍) for the changes. Will someone else (@madmod, @bflad) be able to take this up?

[bflad]

Not a problem, I can add a review commit to yours and get this in for you. Thanks so much for your initial work here, very appreciated!

[bflad]

Ready to go with configurable behavior_on_mx_failure attribute, support for updates, and some additional testing! 🚀

make testacc TEST=./aws TESTARGS='-run=TestAccAwsSESDomainMailFrom'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsSESDomainMailFrom -timeout 120m
=== RUN   TestAccAwsSESDomainMailFrom_basic
--- PASS: TestAccAwsSESDomainMailFrom_basic (22.36s)
=== RUN   TestAccAwsSESDomainMailFrom_behaviorOnMxFailure
--- PASS: TestAccAwsSESDomainMailFrom_behaviorOnMxFailure (22.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.985s

[bflad]

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!