Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ses_domain_mail_from improvements #3445

Closed
sjauld opened this issue Feb 19, 2018 · 4 comments
Closed

r/ses_domain_mail_from improvements #3445

sjauld opened this issue Feb 19, 2018 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.

Comments

@sjauld
Copy link
Contributor

sjauld commented Feb 19, 2018

#2029 adds support for SES MAIL FROM resources. It would be great to output the required DNS records so we can use them directly. I'll work on this if no one else is doing it?

@sjauld
Copy link
Contributor Author

sjauld commented Feb 19, 2018

Just as a note, this would actually be hard coded as it's not provided by the AWS API...

https://docs.aws.amazon.com/ses/latest/DeveloperGuide/regions.html#region-mail-from

@sjauld
Copy link
Contributor Author

sjauld commented Feb 19, 2018

We could even just leave a note in the docs to do something like this:

data aws_region "current" {}

resource aws_route53_record "bounce_mx" {
  zone_id = "${aws_route53_zone.mailer.zone_id}"
  name    = "${var.mail_from_subdomain}"
  type    = "MX"
  ttl     = "300"
  records = ["10 feedback-smtp.${data.aws_region.current.name}.amazonses.com"]
}

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. labels Feb 21, 2018
@bflad
Copy link
Contributor

bflad commented Jun 19, 2019

The current aws_ses_domain_mail_from resource documentation contains an example similar to the last comment above:

resource "aws_ses_domain_mail_from" "example" {
  domain           = "${aws_ses_domain_identity.example.domain}"
  mail_from_domain = "bounce.${aws_ses_domain_identity.example.domain}"
}

# Example SES Domain Identity
resource "aws_ses_domain_identity" "example" {
  domain = "example.com"
}

# Example Route53 MX record
resource "aws_route53_record" "example_ses_domain_mail_from_mx" {
  zone_id = "${aws_route53_zone.example.id}"
  name    = "${aws_ses_domain_mail_from.example.mail_from_domain}"
  type    = "MX"
  ttl     = "600"
  records = ["10 feedback-smtp.us-east-1.amazonses.com"]           # Change to the region in which `aws_ses_domain_identity.example` is created
}

If you have further enhancement or documentation requests, please create a new GitHub issue. Thanks. 👍

@bflad bflad closed this as completed Jun 19, 2019
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
Development

No branches or pull requests

2 participants