Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove network_interface_id #1193

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Remove network_interface_id #1193

merged 1 commit into from
Feb 25, 2019

Conversation

grubernaut
Copy link
Contributor

Finally remove network_interface_id in favor of
primary_network_interface_id.

@grubernaut
Remove network_interface_id
87efd63 
Finally remove `network_interface_id` in favor of
`primary_network_interface_id`.
@grubernaut grubernaut added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 20, 2017
@radeksimko radeksimko added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jul 20, 2017
@catsby
Copy link
Contributor

catsby commented Jul 20, 2017

We discussed that we would delay merging this PR a few days, so please hold of

radeksimko
radeksimko approved these changes Jul 28, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.3 was released, so I think we can now merge this + modify the Changelog accordingly (the next release with BC should be IMO 0.2.0 at least).

@radeksimko radeksimko added this to the v2.0.0 milestone Oct 31, 2017
@radeksimko radeksimko added the size/XS Managed by automation to categorize the size of a PR. label Nov 15, 2017
@radeksimko radeksimko added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jan 12, 2018
bflad
bflad approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time for version 2.0.0 has come! 🚀

@bflad bflad merged commit 4772c39 into master Feb 25, 2019
@bflad bflad deleted the f-deprecate-network-interface-id branch February 25, 2019 17:44
@bflad bflad mentioned this pull request Feb 25, 2019
Merged
bflad added a commit that referenced this pull request Feb 25, 2019
@bflad
Update CHANGELOG for #1193 and #7715
6b50965
@minniux minniux mentioned this pull request Mar 5, 2019
Merged
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@radeksimko radeksimko radeksimko approved these changes

@vladholubiev vladholubiev vladholubiev approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@grubernaut @catsby @bflad @radeksimko @vladholubiev