Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_cloudhsm_v2_cluster: Ensure multiple tag configurations are applied and perform drift detection of tags #10309

Merged
merged 3 commits into from
Oct 25, 2019
Merged

resource/aws_cloudhsm_v2_cluster: Ensure multiple tag configurations are applied and perform drift detection of tags #10309

merged 3 commits into from
Oct 25, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 30, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9871
Includes and supersedes #9741

Release note for CHANGELOG:

* resource/aws_cloudhsm_v2_cluster: Ensure multiple tag configurations are applied
* resource/aws_cloudhsm_v2_cluster: Perform drift detection with tags

Output from acceptance testing:

--- PASS: TestAccAWSCloudHsm2Cluster_Tags (281.94s)
--- PASS: TestAccAWSCloudHsm2Cluster_basic (286.25s)

@bflad bflad added bug Addresses a defect in current functionality. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. labels Sep 30, 2019
@bflad bflad requested a review from a team September 30, 2019 19:30
@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 30, 2019
@bflad
resource/aws_cloudhsm_v2_cluster: Perform drift detection with tags
a49859a 
Reference: #9871

Output from acceptance testing:

```
--- PASS: TestAccAWSCloudHsm2Cluster_Tags (281.94s)
--- PASS: TestAccAWSCloudHsm2Cluster_basic (286.25s)
```
ryndaniels
ryndaniels approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

--- PASS: TestAccAWSCloudHsm2Cluster_Tags (244.79s)
--- PASS: TestAccAWSCloudHsm2Cluster_basic (262.45s)

@bflad bflad added this to the v2.34.0 milestone Oct 25, 2019
@bflad bflad merged commit a49859a into master Oct 25, 2019
@bflad bflad deleted the mudlark-master branch October 25, 2019 14:34
bflad added a commit that referenced this pull request Oct 25, 2019
@bflad
Update CHANGELOG for #10309
5155775
@bflad
Copy link
Contributor Author

bflad commented Oct 31, 2019

This has been released in version 2.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.34.0
Development

Successfully merging this pull request may close these issues.

Adding multiple tags to a cloudHSM cluster does not work
3 participants
@bflad @ryndaniels @mudlark