Small change to fix bug where only 1 tag would be created when multiple specified

[mudlark]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9871

Release note for CHANGELOG:

Fixes a bug in the cloudhsm2 provider that would result in a single tag being created when multiple tags are specified.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceCloudHsm2Cluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceCloudHsm2Cluster_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceCloudHsm2Cluster_basic
--- PASS: TestAccDataSourceCloudHsm2Cluster_basic (339.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	340.585s
$

[bflad]

I have added Closes #9871 to the pull request description so it references the associated issue. This fix looks correct, however the resource itself is not performing drift detection of the tags attribute since it does not call ListTags and d.Set("tags", ...). Rather than manually implementing the new tagging logic, we can use #10018 to create the implementation for us. I have assigned this to myself to work on this immediately after that generated code is in place, which should be soon.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!