terraform_map_duplicate_keys: Temporarily ignore key evaluation errors #200
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199
The
terraform_map_duplicate_keysrule, added in v0.9.0, walks through all expressions and evaluates their values to see if a map has duplicate keys.In most cases, this approach works well because the evaluation scope is the same across the board, but expressions with different scopes, such as for expressions, cannot be evaluated correctly without first expanding the for expressions.
This issue should be resolved at the SDK level, but since it is currently it is not, we will mitigate this issue by temporarily ignoring key evaluation errors. Note that this may result in duplicate keys not being detected correctly when using for expressions.