tflint: Sending expression nodes as a text representation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
text_transmission_over_rpc
branch
from
906c586
to
74f4303
Compare
|
In favor of publishing, I have temporarily dropped support for JSON configuration syntax. I will open an issue later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also hashicorp/hcl#332
Currently, sending and receiving expression nodes via
gobin the plugin system. However, this approach has two problems:json.expressionis not exportedAfter discussing this issue, I got the advice that it's best to use text representation for sending and receiving.
Following the advice, this PR changes that it sends and receives text instead of expression and it to be parsed as an expression by the plugin and host respectively.
Unfortunately, there is no expression-based JSON parsing API in HCL today. I'm opening a PR to add this function, but this pull request is pending until it is merged. See hashicorp/hcl#381