Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cloud logs policies #600

Merged
merged 11 commits into from
Oct 29, 2024
Merged

feat: add cloud logs policies #600

merged 11 commits into from
Oct 29, 2024

Conversation

maheshwarishikha
Copy link
Member

@maheshwarishikha maheshwarishikha commented Oct 24, 2024

Description

Add cloud logs policies (#590)

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add cloud logs policies

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

This time PR failed in EN integration code -

2024/10/25 09:00:55 Terraform apply | module.observability_instances.module.cloud_logs[0].ibm_logs_outgoing_webhook.en_integration["1"]: Creation complete after 4s [id=eu-de/e765aee9-9bd6-45f5-9493-cf0b875ffb80/968730df-7b2e-45fa-97bd-4155f2f61789]
 2024/10/25 09:00:55 Terraform apply | 
 2024/10/25 09:00:55 Terraform apply | Error: ---
 2024/10/25 09:00:55 Terraform apply | id: terraform-693866e6
 2024/10/25 09:00:55 Terraform apply | summary: 'CreateOutgoingWebhookWithContext failed: No authentication information in
 2024/10/25 09:00:55 Terraform apply |   RequestContext'
 2024/10/25 09:00:55 Terraform apply | severity: error
 2024/10/25 09:00:55 Terraform apply | resource: ibm_logs_outgoing_webhook
 2024/10/25 09:00:55 Terraform apply | operation: create
 2024/10/25 09:00:55 Terraform apply | component:
 2024/10/25 09:00:55 Terraform apply |   name: github.com/IBM-Cloud/terraform-provider-ibm
 2024/10/25 09:00:55 Terraform apply |   version: 1.70.1
 2024/10/25 09:00:55 Terraform apply | ---
 2024/10/25 09:00:55 Terraform apply | 
 2024/10/25 09:00:55 Terraform apply | 
 2024/10/25 09:00:55 Terraform apply |   with module.observability_instances.module.cloud_logs[0].ibm_logs_outgoing_webhook.en_integration["0"],

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to support creating multiple policies by using 1 input variable that is a list of objects

@maheshwarishikha
Copy link
Member Author

I suggest to support creating multiple policies by using 1 input variable that is a list of objects

sure, will update the code accordingly.

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. I suggest that you add the policy to the advanced example instead of basic. Thats also the example we run in PR tests

variables.tf Outdated Show resolved Hide resolved
modules/cloud_logs/variables.tf Outdated Show resolved Hide resolved
modules/cloud_logs/README.md Outdated Show resolved Hide resolved
@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

PR failed with EN related issue -

TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: ╷
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ Error: ---
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ id: terraform-693866e6
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ summary: 'CreateOutgoingWebhookWithContext failed: No authentication information in
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │   RequestContext'
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ severity: error
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ resource: ibm_logs_outgoing_webhook
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ operation: create
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ component:
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │   name: github.com/IBM-Cloud/terraform-provider-ibm
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │   version: 1.70.1
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ ---
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ 
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ 
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │   with module.observability_instances.module.cloud_logs[0].ibm_logs_outgoing_webhook.en_integration["1"],
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │   on ../../modules/cloud_logs/main.tf line 109, in resource "ibm_logs_outgoing_webhook" "en_integration":
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │  109: resource "ibm_logs_outgoing_webhook" "en_integration" {
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: │ 
TestRunUpgradeExample 2024-10-29T10:28:06Z logger.go:66: ╵
TestRunUpgradeExample 2024-10-29T10:28:06Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; 

re-running...

@ocofaigh ocofaigh merged commit 17dbaaf into main Oct 29, 2024
2 checks passed
@ocofaigh ocofaigh deleted the sm-11194 branch October 29, 2024 16:09
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants