Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding support for cloud logs #137

Merged
merged 56 commits into from
Sep 20, 2024
Merged

feat: adding support for cloud logs #137

merged 56 commits into from
Sep 20, 2024

Conversation

iamar7
Copy link
Member

@iamar7 iamar7 commented Aug 6, 2024 •
edited
Loading

Description

Resolves: https://github.ibm.com/GoldenEye/issues/issues/9802

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR adds support for cloud logs.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7
Copy link
Member Author

iamar7 commented Aug 9, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 9, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 9, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 9, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 12, 2024

/run pipeline

@iamar7 iamar7 marked this pull request as ready for review August 12, 2024 13:40
@iamar7
Copy link
Member Author

iamar7 commented Aug 12, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 19, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Aug 19, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 16, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 16, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 16, 2024

Skipping upgrade test ~

Screenshot 2024-09-16 at 9 43 14 PM

@iamar7
Copy link
Member Author

iamar7 commented Sep 16, 2024

/run pipeline

@iamar7 iamar7 requested a review from ocofaigh September 17, 2024 05:35
ocofaigh
ocofaigh requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/main.tf Outdated Show resolved Hide resolved
solutions/instances/main.tf Outdated Show resolved Hide resolved
solutions/instances/main.tf Outdated Show resolved Hide resolved
@iamar7
Copy link
Member Author

iamar7 commented Sep 18, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 18, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 19, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 19, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 19, 2024

/run pipeline

@iamar7 iamar7 mentioned this pull request Sep 20, 2024
Closed
6 tasks
@iamar7
Copy link
Member Author

iamar7 commented Sep 20, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 9616b28 into main Sep 20, 2024
2 checks passed
@ocofaigh ocofaigh deleted the 9802-cl branch September 20, 2024 16:00
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamar7 iamar7 mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aashiq-J Aashiq-J Aashiq-J left review comments

@ocofaigh ocofaigh ocofaigh approved these changes

@maheshwarishikha maheshwarishikha maheshwarishikha left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamar7 @maheshwarishikha @ocofaigh @terraform-ibm-modules-ops @Aashiq-J