Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated provider version #106

Merged
merged 7 commits into from
Jan 31, 2024
Merged

fix: updated provider version #106

merged 7 commits into from
Jan 31, 2024

Conversation

Khuzaima05
Copy link
Member

Description

updated provider version
issue : https://github.ibm.com/GoldenEye/issues/issues/6747

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05 Khuzaima05 self-assigned this Jan 12, 2024
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 requested a review from ocofaigh January 12, 2024 12:31
@Khuzaima05
Copy link
Member Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fscloud submodule needs to also be updated
  • the other examples also need to be updated

examples/basic/version.tf Outdated Show resolved Hide resolved
@Khuzaima05
Copy link
Member Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed modules/fscloud/version.tf

@Khuzaima05
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit a619871 into main Jan 31, 2024
2 checks passed
@ocofaigh ocofaigh deleted the issue_6747 branch January 31, 2024 14:31
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.7.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants