-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci] Update CHANGELOG links, add entries for v0.5.0 #84
Conversation
7f2203a
to
21daa99
Compare
This commit updates the CHANGELOG.md to include links for versions, links for pull request entries, separates additions and changes for the unreleased version, catches up pull request of 2019-02-28.
[ci skip]
21daa99
to
e66adbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of links for pull requests and issues should be sorted.
CHANGELOG.md
Outdated
[#22]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/22 | ||
[#19]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/19 | ||
[#16]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/16 | ||
[#15]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated (and an issue).
[#15]: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in incoming replacement PR.
CHANGELOG.md
Outdated
### Added | ||
* Allow creation of service accounts. [#80] | ||
* Add support for private clusters via submodule. [#69] | ||
* Add `remove_default_node_pool` set to `false` by default. Fixes [#15]. [#55] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
55 needs a link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in replacement PR.
CHANGELOG.md
Outdated
* Add `remove_default_node_pool` set to `false` by default. Fixes [#15]. [#55] | ||
* Allow arbitrary key-value pairs to be set on node pool metadata. [#52] | ||
* Add `initial_node_count` parameter to node_pool block. [#60] | ||
* Fix permanent metadata skew due to disable-legacy-endpoints keys [#114] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should move under Fixed. The Added entry should identify the new variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in replacement PR.
CHANGELOG.md
Outdated
### Added | ||
* Allow creation of service accounts. [#80] | ||
* Add support for private clusters via submodule. [#69] | ||
* Add `remove_default_node_pool` set to `false` by default. Fixes [#15]. [#55] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An explanation of what was fixed should go under Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.md
Outdated
|
||
### Fixed | ||
* Zonal clusters can now accept a single zone. Fixes [#43]. [#50] | ||
* Drop explicit version from simple_zonal example. [#74] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go under Changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in replacement PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes are addressed in #115
This commit updates the CHANGELOG.md to include links for versions,
links for pull request entries, separates additions and changes for
the unreleased version, catches up pull request
of 2019-02-28.