Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit versions from test cases and examples #62

Merged

Conversation

Jberlinsky
Copy link
Contributor

At one point, these were necessary to ensure that tests passed, particularly when working with zonal clusters. This does not seem to be the case any longer, and merely add overhead, as they have to be updated to keep tests green.

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jberlinsky Jberlinsky merged commit fe67e90 into master Jan 9, 2019
@aaron-lane aaron-lane deleted the internal/remove-explicit-versioning-from-examples branch January 9, 2019 22:08
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…modules/internal/remove-explicit-versioning-from-examples

Remove explicit versions from test cases and examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants